[actor] Add Unreliable Feedback Type#3849
Conversation
Deploying monorepo with
|
| Latest commit: |
cf05798
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://af102322.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://infallible-feedback.monorepo-eu0.pages.dev |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | cf05798 | May 22 2026, 05:09 AM |
Benchmark resultsTip ✅ PASSED: No benchmark exceeded the regression threshold. Benchmark comparison table
Baseline commit(s): |
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2e16f57. Configure here.
| /// This method should not unwind after mutating `overflow`. A panic, including one from a | ||
| /// destructor triggered while editing `overflow`, can leave retained overflow data stranded in | ||
| /// the mailbox. | ||
| fn handle(overflow: &mut Self::Overflow, message: Self); |
There was a problem hiding this comment.
Very nice that we no longer need to return a boolean here.
patrick-ogrady
changed the title
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e1fbdfb. Configure here.
|
|
||
| /// Feedback from endpoints that may reject work under backpressure. | ||
| #[derive(Clone, Copy, Debug, PartialEq, Eq)] | ||
| pub enum Unreliable<T> { |
There was a problem hiding this comment.
This is kept generic in case we start adding more "outcomes" ... if we eventually go a different route, we can do UnreliableFeedback or something.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #3849 +/- ##
==========================================
- Coverage 95.77% 95.76% -0.02%
==========================================
Files 486 486
Lines 199578 200679 +1101
Branches 4851 4858 +7
==========================================
+ Hits 191147 192172 +1025
- Misses 6806 6873 +67
- Partials 1625 1634 +9
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
1 participant
Resolves: #3825